Release 10.6 final integration #6331
Conversation
…into ana/other-packages-10.6
…into ana/other-packages-10.6
Node 10.6 - make other packages build
| ShelleyBasedEraAlonzo -> 39 -- TODO: check minSize for Alonzo | ||
| ShelleyBasedEraBabbage -> 39 -- TODO: check minSize for Babbage | ||
| ShelleyBasedEraConway -> 39 -- TODO: check minSize for Conway | ||
| ShelleyBasedEraDijkstra -> 39 -- TODO: check minSize for Dijkstra |
There was a problem hiding this comment.
What's up with these TODOs? I know they were there before, and I added a TODO for Dijkstra as well, but are they being tracked by any issue?
| , Ledger.AtMostEra Ledger.MaryEra ledgerera | ||
| , Ledger.AtMostEra Ledger.AlonzoEra ledgerera | ||
| , Ledger.AtMostEra "Mary" ledgerera | ||
| , Ledger.AtMostEra "Alonzo" ledgerera |
There was a problem hiding this comment.
Again, at line 561 and 526 we've got some TODOs which don't seem to be tracked anywhere. Btw, I see that this function already uses PParams, perhaps the TODO should be removed?
| script <- | ||
| handleExceptT (\(e :: SomeException) -> ApiError $ displayException e) (readFileScriptInAnyLang fp) |
There was a problem hiding this comment.
@mgmeier through all the rebases I kept seeing this change come up and I recall you said it shouldn't be necessary. Maybe I/someone messed up the rebases and redid this change, or maybe we need it. Can you confirm which case it is?
| Api.AlonzoEraOnwardsBabbage -> renderAlonzoPlutusPurpose | ||
| Api.AlonzoEraOnwardsConway -> renderConwayPlutusPurpose | ||
| -- TODO: fix | ||
| Api.AlonzoEraOnwardsDijkstra -> undefined |
There was a problem hiding this comment.
This needs to be addressed.
| ] | ||
| forMachine _dtal (TraceLocalRootWaiting d dt) = | ||
| mconcat [ "kind" .= String "LocalRootWaiting" | ||
| -- TODO: `domainAddress` -> `accessPoint` |
There was a problem hiding this comment.
Does this need to be addressed in this PR? Should we open a separate issue?
| (M.notMember stakeKeyHash . L.scDeposits) | ||
| (\accountsStates -> isJust $ do | ||
| _state <- M.lookup stakeKeyHash accountsStates | ||
| pure () -- TODO: should we check for balance? |
There was a problem hiding this comment.
To be addressed after fixing testnet.
| _state <- M.lookup stakeKeyHash accountsStates | ||
| pure () -- TODO: should we check for balance? | ||
| ) | ||
| -- (M.notMember stakeKeyHash . L.scDeposits) |
There was a problem hiding this comment.
Why is this commented out instead of removed?
There was a problem hiding this comment.
this is the previous implementation, to be removed once we fix the testnet tests.
| import qualified Hedgehog as H | ||
| import qualified Hedgehog.Extras as H | ||
|
|
||
| -- TODO we're not supporting non-p2p topology, does this test make any sense now? |
There was a problem hiding this comment.
Sounds like this needs to be addressed.
There was a problem hiding this comment.
I had another look. I'll remove this test.
| let disabledTests = pure $ T.testGroup "tests disabled" [] | ||
|
|
||
| E.withArgs args $ tests >>= T.defaultMainWithIngredients T.defaultIngredients | ||
| -- TODO: fix testnet tests and reenable here |
There was a problem hiding this comment.
Just marking this here as the testnet tests TODO.
There was a problem hiding this comment.
Yes, but it's out of scope for the node 10.6 release.
| ({ lib, pkgs, ... }: lib.mkIf (pkgs.stdenv.hostPlatform != pkgs.stdenv.buildPlatform) { | ||
| # Remove hsc2hs build-tool dependencies (suitable version will be available as part of the ghc derivation) | ||
| packages.Win32.components.library.build-tools = lib.mkForce [ ]; | ||
| # TODO: error: The option `packages.Win32' does not exist. |
We no longer need non-p2p stuff :).
11 participants
Needs #6327 #6290
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.